Cache peer CA names on client side after handshake#2994
Merged
WillChilds-Klein merged 12 commits intoaws:mainfrom Mar 4, 2026
Merged
Cache peer CA names on client side after handshake#2994WillChilds-Klein merged 12 commits intoaws:mainfrom
WillChilds-Klein merged 12 commits intoaws:mainfrom
Conversation
41f1117 to
5b3e4d6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2994 +/- ##
=======================================
Coverage 78.35% 78.36%
=======================================
Files 689 689
Lines 121026 121069 +43
Branches 16966 16968 +2
=======================================
+ Hits 94833 94872 +39
- Misses 25296 25302 +6
+ Partials 897 895 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Feb 18, 2026
skmcgrail
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
OpenSSL docs for SSL_get_client_CA_list stipulate:
AWS-LC’s
SSL_get_client_CA_listbehavior differs from OpenSSL’s behavior on the client side in that AWS-LC keeps its client CA list on thessl->s3->hsstruct that gets reset upon handshake completion whereas OpenSSL keeps its list onsc->s3.tmpwhich appears to retain state after the handshake completes.This PR moves
cached_x509_ca_namesfrom the handshake (ssl->hs) struct to thessl->s3struct to persist them after the handshake completes andssl->hsis reset.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.