Cleanup pass on Go code in repository#2951
Merged
Conversation
1ee713c to
d3f529b
Compare
Member
Author
justsmth
approved these changes
Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
=======================================
Coverage 78.07% 78.08%
=======================================
Files 682 682
Lines 118355 118355
Branches 16609 16610 +1
=======================================
+ Hits 92406 92415 +9
+ Misses 25060 25050 -10
- Partials 889 890 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
golang.org/x/cryptomodule version that was still compatible with Go 1.17. This module version has tagged CVEs, but they aren't relevent to our build/test tools. This is only used for thessl/test/runner, we could in the future be smarter about running or not running tests that require this program based off the detected Go compiler version.go:build ignoretag to the Go programs that were pulling ingithub.com/ethereum/go-ethereum. So this won't be recorded in the top-levelgo.modfile anymore. We could move these into a separate nested module, but these only exist if in the rare event we want to regenerate test cases / understand what generated test cases for us.go fmton the code in the repository, need to add a CI job that actually enforces this....Call-outs:
AWS-LC-Build-Gluescript that drops an alternativego.modfile, as the path will now be incorrect and will cause build failures when trying to buildssl/test/runner.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.