Consolidate FORMAT_DER/PEM in tool-openssl#2929
Merged
samuel40791765 merged 1 commit intoaws:mainfrom Jan 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
+ Coverage 78.17% 78.22% +0.05%
==========================================
Files 690 690
Lines 118663 118737 +74
Branches 16680 16679 -1
==========================================
+ Hits 92759 92885 +126
+ Misses 25017 24965 -52
Partials 887 887 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Jan 5, 2026
| #endif | ||
|
|
||
| // Format enum for PEM and DER output/input formats | ||
| enum Format { |
Contributor
There was a problem hiding this comment.
NP: the type name Format might be ambiguous/overloaded in some contexts.
WillChilds-Klein
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were defined all over the place, consolidating these into one place.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.