Skip to content

fix(target): fix mipseb 64bit compile#2923

Merged
justsmth merged 1 commit intoaws:mainfrom
cathaysia:fix/mipseb_64
Jan 2, 2026
Merged

fix(target): fix mipseb 64bit compile#2923
justsmth merged 1 commit intoaws:mainfrom
cathaysia:fix/mipseb_64

Conversation

@cathaysia
Copy link
Copy Markdown
Contributor

Issues:

Resolves aws/aws-lc-rs#522
Addresses aws/aws-lc-rs#522

Description of changes:

add support for mips big endiness 64bit.

Testing:

after apply this patch, mips64-unknown-linux-muslabi64 could be compiled:

https://github.com/cathaysia/aws-lc-rs-522/actions/runs/20497659307/job/58899733568

Signed-off-by: loongtao.zhang <loongtao.zhang@outlook.com>
@cathaysia cathaysia requested a review from a team as a code owner December 30, 2025 04:48
Copy link
Copy Markdown
Member

@skmcgrail skmcgrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/codebuild_run(db9ddb9)

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.17%. Comparing base (6157ba5) to head (db9ddb9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2923      +/-   ##
==========================================
- Coverage   78.35%   78.17%   -0.18%     
==========================================
  Files         690      690              
  Lines      118668   118667       -1     
  Branches    16686    16682       -4     
==========================================
- Hits        92985    92771     -214     
- Misses      24792    25008     +216     
+ Partials      891      888       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth
Copy link
Copy Markdown
Contributor

justsmth commented Jan 2, 2026

Thanks for the PR! :-)

@justsmth
Copy link
Copy Markdown
Contributor

justsmth commented Jan 2, 2026

We had a similar fix for 32-bit here: https://github.com/aws/aws-lc/pull/2143/changes

@justsmth justsmth merged commit 491226c into aws:main Jan 2, 2026
390 of 400 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No mips-unknown-linux-musl support

5 participants