Skip to content

Add randomized unit testing for EVP_CIPHERs#2922

Merged
dkostic merged 4 commits intoaws:mainfrom
dkostic:evp-cipher-randomized-tests
Jan 2, 2026
Merged

Add randomized unit testing for EVP_CIPHERs#2922
dkostic merged 4 commits intoaws:mainfrom
dkostic:evp-cipher-randomized-tests

Conversation

@dkostic
Copy link
Copy Markdown
Contributor

@dkostic dkostic commented Dec 29, 2025

Issues:

N/A

Description of changes:

Added a unit test that performs end-to-end testing of all
EVP_CIPHERs with random key, IV, plaintext, aad.

Call-outs:

Locally, I reverted the XTS fix (3f282aa) and verified that this new unit test would catch the bug.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Added a unit test that performs end-to-end testing of all
EVP_CIPHERs with random key, IV, plaintext, aad.
@dkostic dkostic requested a review from a team as a code owner December 29, 2025 18:25
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.22%. Comparing base (6157ba5) to head (0aa8d89).

Files with missing lines Patch % Lines
crypto/cipher_extra/cipher_test.cc 98.63% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2922      +/-   ##
==========================================
- Coverage   78.35%   78.22%   -0.14%     
==========================================
  Files         690      690              
  Lines      118668   118741      +73     
  Branches    16686    16681       -5     
==========================================
- Hits        92985    92880     -105     
- Misses      24792    24972     +180     
+ Partials      891      889       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

samuel40791765
samuel40791765 previously approved these changes Dec 29, 2025
@skmcgrail skmcgrail self-requested a review December 29, 2025 21:46
skmcgrail
skmcgrail previously approved these changes Dec 29, 2025
@dkostic dkostic dismissed stale reviews from skmcgrail and samuel40791765 via 7df982c December 29, 2025 22:34
samuel40791765
samuel40791765 previously approved these changes Dec 29, 2025
skmcgrail
skmcgrail previously approved these changes Dec 30, 2025
samuel40791765
samuel40791765 previously approved these changes Dec 30, 2025
@dkostic dkostic enabled auto-merge (squash) December 30, 2025 17:33
@dkostic dkostic merged commit fe6ffcb into aws:main Jan 2, 2026
474 of 478 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants