Fix the libwebsockets integration test script#2912
Merged
Conversation
Contributor
WillChilds-Klein
left a comment
There was a problem hiding this comment.
Don't we still need to fix the patch?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
=======================================
Coverage 78.16% 78.17%
=======================================
Files 690 690
Lines 118667 118667
Branches 16681 16680 -1
=======================================
+ Hits 92756 92765 +9
+ Misses 25024 25012 -12
- Partials 887 890 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: dkostic <dkostic@amazon.com>
2a342cc to
401855b
Compare
samuel40791765
approved these changes
Dec 23, 2025
justsmth
approved these changes
Dec 23, 2025
skmcgrail
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
The libwebsockets integration test is failing to apply a patch:
I added
--forwardoption to thepatchcommand to skip applying the patch if it's not needed.Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.