Fix incorrect assembler directive in AArch64 code#2910
Merged
Conversation
If opcodes are written in assembly such as .long 0x1234, they create data mapping symbols and throw off binary analysis tools such as llvm-bolt. Making them as instructions using .inst directive creates valid disassembly. Signed-off-by: Hemant Kulkarni <hkulkar@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2910 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 687 687
Lines 118576 118576
Branches 16671 16673 +2
=======================================
Hits 92665 92665
- Misses 25023 25025 +2
+ Partials 888 886 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebeid
approved these changes
Dec 16, 2025
justsmth
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #29091
Addresses #ISSUE-NUMBER2
Description of changes:
Fixed the instruction with correct assembler directive.
Call-outs:
None.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
FIPS Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.