[FIPS 2024 - CHERRY_PICK] Offer P521 for signature_algorithms in client Hello (#2572)#2731
Merged
WillChilds-Klein merged 1 commit intoaws:fips-2024-09-27from Oct 6, 2025
Merged
Conversation
WillChilds-Klein
approved these changes
Oct 6, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #2731 +/- ##
================================================
Coverage 78.57% 78.58%
================================================
Files 585 585
Lines 101047 101047
Branches 14311 14312 +1
================================================
+ Hits 79400 79407 +7
+ Misses 21009 21003 -6
+ Partials 638 637 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick onto fips-2024-09-27. Original PR for main:
I needed to resolve a merge conflict for the ssl_test.cc changes.
Issues:
n/a
Description of changes:
This change adds ECDSA P521 to our list of supported certificate verification algorithms in client Hello.
Call-outs:
n/a
Testing:
CI for automated tests. Manual test to confirm
signature_algorithmsextension contents before/after:Client Hello before:
Client Hello after:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.