Skip to content

Fix python main diff after upstream PR 135402 merge#2542

Merged
WillChilds-Klein merged 1 commit into
aws:mainfrom
WillChilds-Klein:fix-python-patch
Jul 15, 2025
Merged

Fix python main diff after upstream PR 135402 merge#2542
WillChilds-Klein merged 1 commit into
aws:mainfrom
WillChilds-Klein:fix-python-patch

Conversation

@WillChilds-Klein

Copy link
Copy Markdown
Contributor

Issues:

n/a

Description of changes:

Updating our python main CI patch now that upstream PR 135402 has been merged.

Call-outs:

n/a

Testing:

  • CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review July 14, 2025 22:20
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner July 14, 2025 22:20
@darylmartin100

Copy link
Copy Markdown
Contributor

Why not just delete the patch outright?

@codecov-commenter

codecov-commenter commented Jul 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.69%. Comparing base (02ab2cb) to head (d76e666).
⚠️ Report is 449 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2542      +/-   ##
==========================================
- Coverage   78.70%   78.69%   -0.01%     
==========================================
  Files         644      644              
  Lines      110503   110503              
  Branches    15643    15643              
==========================================
- Hits        86969    86958      -11     
- Misses      22837    22845       +8     
- Partials      697      700       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WillChilds-Klein WillChilds-Klein merged commit c97db40 into aws:main Jul 15, 2025
121 of 125 checks passed
@WillChilds-Klein WillChilds-Klein deleted the fix-python-patch branch July 15, 2025 15:14
@WillChilds-Klein

Copy link
Copy Markdown
Contributor Author

Why not just delete the patch outright?

@darylmartin100 -- The remaining patch file just configures static linkage of AWS-LC to CPython. Here's a PR to dynamically link AWS-LC when testing against CPython's main, matching our upstream CI job in CPython's repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants