Add suport for asl and rol to match existing support for asr and ror#2185
Merged
Add suport for asl and rol to match existing support for asr and ror#2185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 612 612
Lines 106064 106064
Branches 14994 14993 -1
=======================================
+ Hits 83833 83836 +3
+ Misses 21579 21575 -4
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. |
justsmth
previously approved these changes
Feb 10, 2025
Contributor
|
Failing for x86-64. 😞 How hard would it be to have separate grammars for x86-64 and ARM? |
jakemas
approved these changes
Feb 10, 2025
skmcgrail
previously approved these changes
Feb 10, 2025
justsmth
previously approved these changes
Feb 11, 2025
75c59c3 to
18a85f0
Compare
justsmth
approved these changes
Feb 12, 2025
torben-hansen
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Looking at #2177 I noticed there were some obvious omissions for the ARM constant tweak. This change adds the left version of the right instructions we already have in case a compiler ever decides to use it in the future.
Testing:
Added new test code for the instructions, also updated delocate_test.go to print the first difference after printing the total file:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.