Merged
Conversation
WillChilds-Klein
approved these changes
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2106 +/- ##
==========================================
+ Coverage 78.75% 78.92% +0.17%
==========================================
Files 598 610 +12
Lines 103656 105120 +1464
Branches 14720 14903 +183
==========================================
+ Hits 81635 82968 +1333
- Misses 21368 21499 +131
Partials 653 653 ☔ View full report in Codecov by Sentry. |
manastasova
approved these changes
Jan 10, 2025
| #define ED25519_PUBLIC_KEY_OFFSET 32 | ||
|
|
||
| #ifdef ENABLE_DILITHIUM | ||
| #define FIPS_EVP_PKEY_METHODS 7 |
Contributor
There was a problem hiding this comment.
Is this value not changing?
Contributor
Author
There was a problem hiding this comment.
We're marking ML-DSA as a NON_FIPS_EVP_PKEY_METHODS and yes it went from 3 to 4
Contributor
There was a problem hiding this comment.
I thought it was a FIPS_EVP_PKEY_METHODS before moving it outside the fipsmodule and now a change is needed in the FIPS_EVP_PKEY_METHODS count.
nvm, thanks!
justsmth
approved these changes
Jan 10, 2025
Contributor
|
The "aws-lc-rs" CI failure appear unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #CryptoAlg-2827
Description of changes:
enable_dilithiumflagCall-outs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.