[fips-2024-09-27] Cherry-pick PR 1924, KBKDF kdk length indicator checks#1931
Merged
skmcgrail merged 1 commit intoaws:fips-2024-09-27from Oct 18, 2024
Merged
[fips-2024-09-27] Cherry-pick PR 1924, KBKDF kdk length indicator checks#1931skmcgrail merged 1 commit intoaws:fips-2024-09-27from
skmcgrail merged 1 commit intoaws:fips-2024-09-27from
Conversation
…ts. (aws#1924) ### Description of changes: * KBKDF: Per SP 800-131Ar1, Section 8: "The length of the key-derivation key shall be at least 112 bits.” There must be a non-approved service indicator for KBKDF with KDK < 112 bits. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit f815a93)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #1931 +/- ##
===================================================
+ Coverage 78.48% 78.57% +0.09%
===================================================
Files 585 585
Lines 99543 100499 +956
Branches 14244 14252 +8
===================================================
+ Hits 78125 78971 +846
- Misses 20782 20892 +110
Partials 636 636 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebeid
approved these changes
Oct 18, 2024
darylmartin100
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1924
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.