Remove source patches for python main integration test#1681
Merged
WillChilds-Klein merged 1 commit intoaws:mainfrom Jul 1, 2024
Merged
Remove source patches for python main integration test#1681WillChilds-Klein merged 1 commit intoaws:mainfrom
WillChilds-Klein merged 1 commit intoaws:mainfrom
Conversation
As of [CPython PR #117785][1], CPython can now build against AWS-LC without any source code modifications. The only patches we still require are to configure the build and work around ([expected][2]) test failures. [1]: python/cpython#117785 [2]: https://discuss.python.org/t/support-building-ssl-and-hashlib-modules-against-aws-lc/44505/4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
==========================================
- Coverage 78.27% 78.23% -0.04%
==========================================
Files 566 566
Lines 95197 95197
Branches 13665 13663 -2
==========================================
- Hits 74511 74479 -32
- Misses 20092 20123 +31
- Partials 594 595 +1 ☔ View full report in Codecov by Sentry. |
samuel40791765
approved these changes
Jul 1, 2024
andrewhop
approved these changes
Jul 1, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
n/a
Description of changes:
As of CPython PR #117785, CPython can now build against AWS-LC without any source code modifications. The only patches we still require are to configure the build and work around (expected) test failures.
Call-outs:
n/a
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.