Replace OPENSSL_NO_TLS_PHA with SSL_VERIFY_POST_HANDSHAKE#1668
Merged
WillChilds-Klein merged 1 commit intoaws:mainfrom Jun 26, 2024
Merged
Replace OPENSSL_NO_TLS_PHA with SSL_VERIFY_POST_HANDSHAKE#1668WillChilds-Klein merged 1 commit intoaws:mainfrom
WillChilds-Klein merged 1 commit intoaws:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 566 566
Lines 95193 95193
Branches 13665 13663 -2
=======================================
+ Hits 74465 74466 +1
Misses 20133 20133
+ Partials 595 594 -1 ☔ View full report in Codecov by Sentry. |
darylmartin100
approved these changes
Jun 26, 2024
torben-hansen
approved these changes
Jun 26, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
PR #1526 introduced the
OPENSSL_NO_TLS_PHAdirective mostly for the purposes of AWS-LC's compatibility with CPython, but in cpython PR #117785 @encukou points out that detecting the absence of OpenSSL's ownSSL_VERIFY_POST_HANDSHAKEdirective is sufficient. This change removes AWS-LC'sOPENSSL_NO_TLS_PHAdirective in favor of detecting absence ofSSL_VERIFY_POST_HANDSHAKE.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.