Conversation
bmoffatt
reviewed
Mar 28, 2022
| module github.com/aws/aws-lambda-go | ||
|
|
||
| go 1.12 | ||
| go 1.18 |
Collaborator
There was a problem hiding this comment.
could this break any consumers still using older versions? There's no code changes in this package that require a new minimum version but am thinking about if module aware go get on version 1.12 -> 1.17 is gonna complain about this.
Collaborator
There was a problem hiding this comment.
guess it'll be fine 🤷♂️
testing:
pushed this: https://github.com/bmoffatt/test/blob/4225d22556144454019816fa24ec561f3b77924e/go.mod#L3
then did this:
~/test2
$ go version
go version go1.17.8 darwin/amd64
~/test2
$ cat main.go
package main
import (
"log"
"github.com/bmoffatt/test"
)
func main() {
log.Print(test.Test())
}
~/test2
$ go mod init test-test-test
go: creating new go.mod: module test-test-test
go: to add module requirements and sums:
go mod tidy
~/test2
$ go mod tidy
go: finding module for package github.com/bmoffatt/test
go: found github.com/bmoffatt/test in github.com/bmoffatt/test v0.0.0-20220329001020-4225d2255614
~/test2
$ go run ./main.go
2022/03/28 17:14:22 test
bmoffatt
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Housekeeping - ran:
go list -m -u allgo get github.com/urfave/cli/v2@v2.4.0go mod tidyAlso updated go version in
go.modfrom 1.12 to 1.18By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.