moving test selection to pytest markers#41
Merged
mattsb42-aws merged 5 commits intoaws:masterfrom Jan 13, 2018
mattsb42-aws:dev-23
Merged
moving test selection to pytest markers#41mattsb42-aws merged 5 commits intoaws:masterfrom mattsb42-aws:dev-23
mattsb42-aws merged 5 commits intoaws:masterfrom
mattsb42-aws:dev-23
Conversation
lizroth
approved these changes
Jan 13, 2018
This was referenced Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves our test selection logic from using environment variables to filter out tests run in a large batch to instead using pytest markers to select specific tests. In addition to being simpler to maintain, this both allows each test environment to run fewer tests and makes it much clearer in our CI which types of tests fail (ex: if credentials are not found, only integration, acceptance, and examples tests will fail).
This adds six markers:
Validating that all tests are caught, the counts for tests run and skipped when filtering for each marker: