docs: add master key provider examples#236
Merged
mattsb42-aws merged 7 commits intoaws:keyringfrom Apr 6, 2020
mattsb42-aws:mkp-examples
Merged
docs: add master key provider examples#236mattsb42-aws merged 7 commits intoaws:keyringfrom mattsb42-aws:mkp-examples
mattsb42-aws merged 7 commits intoaws:keyringfrom
mattsb42-aws:mkp-examples
Conversation
Member
Author
|
Note for the record: all failing checks are expected. They are all from the test vector handler workflow. The tests from that workflow actually should not be running on pull request events, but I'll figure that out in a different PR. |
| # SPDX-License-Identifier: Apache-2.0 | ||
| """ | ||
| This example is provided as a reference for users migrating away from master key providers. | ||
| We recommend that all new use should use keyrings. |
Contributor
There was a problem hiding this comment.
this wording is a little awkward
Co-Authored-By: Wesley Rosenblum <55108558+WesleyRosenblum@users.noreply.github.com>
WesleyRosenblum
approved these changes
Apr 3, 2020
Contributor
WesleyRosenblum
left a comment
There was a problem hiding this comment.
Java PR has been updated to match this: aws/aws-encryption-sdk-java#168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#213
#146
Description of changes:
To aid in migration efforts, these examples show the basics of how to use master key providers in the new example format.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: