remove install dependency on typing#167
Merged
ajw-aws merged 1 commit intoaws:masterfrom Oct 15, 2019
mattsb42-aws:dev-166
Merged
remove install dependency on typing#167ajw-aws merged 1 commit intoaws:masterfrom mattsb42-aws:dev-166
ajw-aws merged 1 commit intoaws:masterfrom
mattsb42-aws:dev-166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes our install dependency on typing and adds shims on failed imports where necessary.
Issue #, if available:
fixes #166
Description of changes:
I was unable to duplicate the reported issue that triggered #166, but after considering how we are actually using
typing(ie: only for typehints), I think that the right answer is to remove our install dependency entirely.We only need
typingto actually exist and work correctly when we do our type analysis, and we always run that with a version newer than 3.5.2, and the shims let the code work as intended whentypingis not present.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.