Handle unprocessed items in batch write responses#107
Handle unprocessed items in batch write responses#107mattsb42-aws merged 7 commits intoaws:masterfrom
Conversation
…laintext versions
|
Hi @woodyza, thanks for this! I'm taking a look at the code today.
Yes, we would like end-to-end tests through all affected high-level clients as well. |
mattsb42-aws
left a comment
There was a problem hiding this comment.
I haven't gone through the tests yet, but wanted to get these notes out since I'll be busy for a while today.
|
Sweet thanks @mattsb42-aws - I'll get onto these later on today. Btw any pointers toward where the higher-level tests would best be implemented? I'm still figuring out the structure of the tests and how they interact with tox and the different test runs. Bit of a tox n00b tbh, don't spend a lot of time on library code that needs to work on more than one python version or platform. |
The categories are described here[1]. Notably:
What I would have in mind for end-to-end tests for this behavior would be [1] https://github.com/aws/aws-dynamodb-encryption-python/blob/master/setup.cfg#L17-L30 |
|
@mattsb42-aws I think I've tackled all your comments so far, I'm just jumping into the e2e tests now. |
mattsb42-aws
left a comment
There was a problem hiding this comment.
Minor formatting fix that autoformat will take care of. Other than that, LGTM.
|
No probs! Thanks for the patient reviewing 😄 |
|
@woodyza |
Addresses #92, #91
Changes the encrypt_batch_write_item utility method to check for UnprocessedItems in the response, and replace them with the original plaintext items.
Couple talking points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.