Add error message when flit_core is not installed #7664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## source-distribution #7664 +/- ##
=======================================================
- Coverage 93.04% 92.96% -0.09%
=======================================================
Files 354 354
Lines 37452 37452
Branches 6008 6008
=======================================================
- Hits 34846 34816 -30
- Misses 1949 1972 +23
- Partials 657 664 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kyleknap
reviewed
Feb 14, 2023
Contributor
kyleknap
left a comment
There was a problem hiding this comment.
Looks fine. Just had a small comment.
backends/build_system/utils.py
Outdated
| except ImportError: | ||
| flit_core_range = get_flit_core_range() | ||
| raise RuntimeError( | ||
| f'In order to check dependencies the environment must have ' |
Contributor
There was a problem hiding this comment.
I wonder if it makes sense to make mention of the --with-download-deps flag here as well?
9fb5f21 to
460c2bf
Compare
e05900c to
12d1742
Compare
460c2bf to
ee448d7
Compare
ee448d7 to
f9c7813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.