Deprecate datapipeline create-default-roles#6678
Merged
stealthycoin merged 1 commit intoaws:developfrom Feb 1, 2022
Merged
Conversation
nateprewitt
suggested changes
Jan 27, 2022
Contributor
nateprewitt
left a comment
There was a problem hiding this comment.
We may want to also update the tests to capture the warning with pytest.warns or @pytest.mark.filterwarnings.
tests/unit/customizations/datapipeline/test_create_default_role.py::TestCreateDefaultRole::test_constructed_result
tests/unit/customizations/datapipeline/test_create_default_role.py::TestCreateDefaultRole::test_default_roles_exist
tests/unit/customizations/datapipeline/test_create_default_role.py::TestCreateDefaultRole::test_default_roles_not_exist
/home/runner/work/aws-cli/aws-cli/awscli/customizations/datapipeline/createdefaultroles.py:75: UserWarning:
Support for this command has been deprecated and may fail to create these roles
if they do not already exist.
warnings.warn(_DEPRECATION_NOTICE)
Codecov Report
@@ Coverage Diff @@
## develop #6678 +/- ##
========================================
Coverage 92.84% 92.85%
========================================
Files 204 204
Lines 16293 16298 +5
========================================
+ Hits 15128 15133 +5
Misses 1165 1165
Continue to review full report at Codecov.
|
e6489c5 to
d8a19c0
Compare
stealthycoin
approved these changes
Jan 31, 2022
nateprewitt
approved these changes
Feb 1, 2022
d8a19c0 to
cfb01d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for the underlying managed policies will be deprecated with no replacement meaning this custom command will no longer function properly if the roles do not already exist. This removes the command from the documentation and prints a warning notice that the command has been deprecated.