Skip to content

[customizations/eks]: Update credential API version#6289

Merged
stealthycoin merged 1 commit intoaws:developfrom
micahhausler:eks-get-token-update
Jul 28, 2021
Merged

[customizations/eks]: Update credential API version#6289
stealthycoin merged 1 commit intoaws:developfrom
micahhausler:eks-get-token-update

Conversation

@micahhausler
Copy link
Copy Markdown
Member

@micahhausler micahhausler commented Jul 21, 2021

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes
v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes
versions v1.16 through v1.21. This is a breaking change for clients running
versions v1.10 and older, which haven't been supported by EKS since September
2019.

Signed-off-by: Micah Hausler mhausler@amazon.com

Issue #, if available:
N/A

Description of changes:

Update Kubernetes client authentication API version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@micahhausler micahhausler force-pushed the eks-get-token-update branch from a8b50d8 to 2378426 Compare July 21, 2021 20:24
stealthycoin
stealthycoin reviewed Jul 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@stealthycoin stealthycoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you add a change log by running:

./scripts/new-change -t enhancement -c eks -d "Short description here."

then adding/comitting the file it writes.

@micahhausler
[customizations/eks]: Update credential API version
3569d49 
Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes
v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes
versions v1.16 through v1.21. This is a breaking change for clients running
versions v1.10 and older, which haven't been supported by EKS since September
2019.

Signed-off-by: Micah Hausler <mhausler@amazon.com>
@micahhausler micahhausler force-pushed the eks-get-token-update branch from 2378426 to 3569d49 Compare July 28, 2021 16:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #6289 (2378426) into develop (7734cee) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2378426 differs from pull request most recent head 3569d49. Consider uploading reports for the commit 3569d49 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6289   +/-   ##
========================================
  Coverage    92.81%   92.81%           
========================================
  Files          204      204           
  Lines        16201    16201           
========================================
  Hits         15037    15037           
  Misses        1164     1164
Impacted Files Coverage Δ
awscli/customizations/eks/get_token.py 100.00% <ø> (ø)
awscli/customizations/eks/update_kubeconfig.py 97.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7734cee...3569d49. Read the comment docs.

@stealthycoin stealthycoin merged commit 1b1fa0e into aws:develop Jul 28, 2021
@micahhausler micahhausler deleted the eks-get-token-update branch July 28, 2021 21:35
@z0rc z0rc mentioned this pull request Jul 29, 2021
Closed
@stevehipwell
Copy link
Copy Markdown

stevehipwell commented Jul 29, 2021

When will these changes be included in v2 (sorry I'm unfamiliar with the workflow here)?

@ndegory
Copy link
Copy Markdown

ndegory commented Jul 30, 2021

@stevehipwell , it's in 2.2.24.

@ndegory ndegory mentioned this pull request Jul 30, 2021
Closed
@stevehipwell
Copy link
Copy Markdown

stevehipwell commented Jul 30, 2021

I think there might have been a lack of communication around this change?

@scouturier scouturier mentioned this pull request Jul 30, 2021
Closed
@dylanlingelbach dylanlingelbach mentioned this pull request Jul 30, 2021
Closed
2 tasks
@nateprewitt nateprewitt mentioned this pull request Jul 30, 2021
Merged
@tei-k tei-k mentioned this pull request Aug 2, 2021
Merged
@tei-k tei-k mentioned this pull request Aug 12, 2021
Merged
@micahhausler micahhausler mentioned this pull request Oct 13, 2021
Merged
@z0rc z0rc mentioned this pull request Nov 16, 2021
Closed
@kdaily kdaily added customization Issues related to CLI customizations (located in /awscli/customizations) eks-get-token labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stealthycoin stealthycoin stealthycoin left review comments

@nckturner nckturner nckturner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

customization Issues related to CLI customizations (located in /awscli/customizations) eks-get-token

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@micahhausler @codecov-commenter @stevehipwell @ndegory @stealthycoin @nckturner @kdaily