Support exporting DefinitionS3Location in AWS::StepFunctions::StateMachine#5222
Merged
kyleknap merged 2 commits intoaws:developfrom Jun 2, 2020
shunjd:develop
Merged
Support exporting DefinitionS3Location in AWS::StepFunctions::StateMachine#5222kyleknap merged 2 commits intoaws:developfrom shunjd:develop
kyleknap merged 2 commits intoaws:developfrom
shunjd:develop
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5222 +/- ##
========================================
Coverage 93.97% 93.98%
========================================
Files 188 188
Lines 14550 14557 +7
========================================
+ Hits 13674 13681 +7
Misses 876 876
Continue to review full report at Codecov.
|
|
Do you think support for Serverless StateMachine DefinitionUri can be added too? |
kyleknap
reviewed
Jun 1, 2020
Contributor
kyleknap
left a comment
There was a problem hiding this comment.
Looks fine. Just had a few comments.
tests/unit/customizations/cloudformation/test_artifact_exporter.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
AWS StepFunctions just released the new property
DefinitionS3Locationwhich is similar to BodyS3Location in AWS::ApiGateway::RestApi.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.