Fix #3618 s3uploader writing to stdout#4147
Merged
justindho merged 1 commit intoaws:developfrom May 27, 2022
Merged
Conversation
The package command writes the template out to stdout. Having the status written on stderr results in the standard practice of piping stdout to a template file to break. eg. aws cloudformation package --template-file cloudformation.yaml --s3-bucket goehd-test > cloudformation.pkg This results in the value \rUploading ... In the first line of the output with deploy complaining about mapped values not being allowed in <unicode string>. Redirecting this to stderr reverts the behavior to be compliant with standard practice.
justindho
approved these changes
May 27, 2022
Contributor
justindho
left a comment
There was a problem hiding this comment.
Thanks, @cthulhuology!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package command writes the template out to stdout. Having the
status written on stderr results in the standard practice of piping
stdout to a template file to break.
eg. aws cloudformation package --template-file cloudformation.yaml
--s3-bucket goehd-test > cloudformation.pkg
This results in the value
\rUploading ...
In the first line of the output with deploy complaining about
mapped values not being allowed in .
Redirecting this to stderr reverts the behavior to be compliant with
standard practice.
Issue #3618
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.