Skip to content

Non zero RC for S3 sync even if file is excluded #1117

@jamesls

Description

@jamesls

A file that would is --exclude'd should not trigger a non zero RC if we can't read the file. For example:

/tmp $ mkdir demo
/tmp $ mkfifo demo/bad
/tmp $ touch demo/good
/tmp $ aws s3 sync demo/ s3://bucket/demo/ --exclude '*' --dryrun
warning: Skipping file /private/tmp/demo/bad. File is character special device, block special device, FIFO, or socket.
Completed 0 part(s) with ... file(s) remaining
/tmp $ echo $?
2

Given that /tmp/demo/bad was never going to be transferred in the first place (because it's been excluded via --exclude '*', it seems odd that this will trigger a non zero RC. I'd expect the RC to be 0 here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    automation-exemptIssue will not be subject to stale-botbugThis issue is a bug.p2This is a standard priority issues3s3filterss3sync

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions