feat(cli): support hotswap for AWS::BedrockAgentCore::Runtime#991
feat(cli): support hotswap for AWS::BedrockAgentCore::Runtime#991
Conversation
5155ead to
f7ffdf2
Compare
f7ffdf2 to
b5410fb
Compare
b5410fb to
66a637d
Compare
66a637d to
2637f13
Compare
2637f13 to
6463a62
Compare
558db52 to
6463a62
Compare
6463a62 to
344769d
Compare
04bbb7c to
234357a
Compare
234357a to
6cdd150
Compare
…tswap-agentcore-runtime
|
It seems the integ test failed in CI because of the architecture for docker.
https://github.com/aws/aws-cdk-cli/actions/runs/20919824142/job/60103434163?pr=991 So I specified |
|
hotswap always succeeds, but occasionally the integ test fails with the following error during
https://github.com/aws/aws-cdk-cli/actions/runs/20922265466/job/60130369126?pr=991 Therefore, just in case, I changed it to pass the stack name instead of the stack ID. I have confirmed that the test succeeds locally. Could you please try running the integ test again? |
|
I have modified the integ test because errors still occurred (See the following points). Could you please run the integ test again? Please let me know if there's a better way. Specified regions in the testAgentCore Runtime is not yet supported in some regions (such as eu-central-2. See: https://docs.aws.amazon.com/bedrock-agentcore/latest/devguide/agentcore-regions.html), and the integ test seems to fail when run in those regions. Therefore, I have modified the test to focus only on supported regions.
Shortened the stack nameThe stack name overflow error is still occurring, so I have tried to shorten the stack name in just case.
|
mrgrain
left a comment
There was a problem hiding this comment.
Urgh. Of course that's an issue. 🤦🏻 I'll check with team what options we have.
|
We are working on something. In the meantime, I am approving this PR. |
Fixes #947
This PR adds hotswap support for
AWS::Bedrock::AgentRuntime.This feature can detect both of S3 code files and ECR images changes to deploy with hotswap.
Changes
@aws-sdk/client-bedrock-agentcore-controldependency3. Added yarnresolutionsto prevent ESM/CommonJS incompatibility (see the comment for details)4. Modifiedyarn-clingto support yarn resolutions field (see the comment for rationale)Note on 3 and 4: I chose this approach to resolve build failures after adding the Bedrock SDK, though I'm not certain it's the optimal solution. If there's a better approach, I'd welcome your feedback. See the commit "3904aab4" for details. FYI, I deleted the yarn.lock file and did a clean install again instead of resolutions, but I got the same error.Tried to revert the commit and modify the lock file manually, build succeeded.
To be specific, after installing
@aws-sdk/client-bedrock-agentcore-control, this change was automatically made. I then manually reverted everything except"@aws-sdk/client-bedrock-agentcore-control@^3":(since it was not directly related to that SDK). The build then succeeded.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license