feat(toolkit-lib): emit marker messages during actions#219
feat(toolkit-lib): emit marker messages during actions#219aws-cdk-automation merged 5 commits intomainfrom
Conversation
7af9478 to
444fefb
Compare
444fefb to
bc6483c
Compare
There was a problem hiding this comment.
All added messages are traces and won't show up in regular logging configurations (like our cli).
bc6483c to
eec20b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 84.84% 84.86% +0.01%
==========================================
Files 208 208
Lines 35564 35563 -1
Branches 4612 4612
==========================================
+ Hits 30175 30179 +4
+ Misses 5239 5237 -2
+ Partials 150 147 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d8266f5 to
3345ac7
Compare
packages/@aws-cdk/tmp-toolkit-helpers/src/api/cloud-assembly/stack-selector.d.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/tmp-toolkit-helpers/src/api/io/payloads/deploy.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/tmp-toolkit-helpers/src/api/io/private/marker.ts
Outdated
Show resolved
Hide resolved
| /** | ||
| * Create a new marker from a given registry entry | ||
| */ | ||
| public marker<S extends MarkerStart, E extends MarkerEnd>(type: MarkerDefinition<S, E>): Marker<S, E> { |
There was a problem hiding this comment.
...and I would call this something like begin.
There was a problem hiding this comment.
I kept the ioHelper.span(...).begin(...) approach. API looks nicer to me that way.
packages/@aws-cdk/tmp-toolkit-helpers/src/api/io/payloads/bootstrap-environment-progress.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Bundling currently takes a while because the declaration bundling started to scan through sdk packages. I plan to fix/work-around/whatever, but in the meantime make this slightly faster by doing all work in parallel.
There was a problem hiding this comment.
Needs to move to shared because it is used in payloads.
3345ac7 to
26186ee
Compare
Introduces the new concept of "Message Spans" to connect multiple messages for toolkit sub-tasks like "synth" or "build-assets" together. A span consists of a number of messages that have the same
spanvalue.At a minimum, a span is a pair of a
startand anendmessage. Every end message also reports the elapsed time since the start of the span.Message spans will allow integrators to more easily track the flow of "tasks" completed in the Toolkit.
Changes
Timerclass to "Message Spans"IoHelperto provide a nicer APIFixes aws/aws-cdk#33286
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license