Skip to content

revert: glob patterns ignored in chokidar v4#1132

Merged
aws-cdk-automation merged 1 commit intomainfrom
revert-1131-conroy/chokidar
Feb 11, 2026
Merged

revert: glob patterns ignored in chokidar v4#1132
aws-cdk-automation merged 1 commit intomainfrom
revert-1131-conroy/chokidar

Conversation

@kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Feb 11, 2026

Reverts #1131

There are additional glob patterns that the PR does not catch.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc changed the title revert: "fix(cli): glob patterns ignored in chokidar v4" revert: glob patterns ignored in chokidar v4 Feb 11, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2026 14:32
@github-actions github-actions bot added the p2 label Feb 11, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.70%. Comparing base (4f58bf1) to head (6b55218).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   87.75%   87.70%   -0.06%     
==========================================
  Files          73       72       -1     
  Lines       10228    10116     -112     
  Branches     1372     1337      -35     
==========================================
- Hits         8976     8872     -104     
+ Misses       1226     1218       -8     
  Partials       26       26              
Flag Coverage Δ
suite.unit 87.70% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 756d6c2 Feb 11, 2026
43 of 45 checks passed
@aws-cdk-automation aws-cdk-automation deleted the revert-1131-conroy/chokidar branch February 11, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants