fix: checking CdkBootstrapVersion when the SSM parameter is encrypted
#1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CdkBootstrapVersion when the SSM parameter is encrypted
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 87.71% 87.75% +0.03%
==========================================
Files 72 72
Lines 10087 10087
Branches 1330 1330
==========================================
+ Hits 8848 8852 +4
+ Misses 1214 1210 -4
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom bootstrap template, users may choose to store the bootstrap version in a
SecureStringSSM parameter instead the defaultStringtype. The CDK CLI currently doesn't request decryption, causing it to fail when reading such parameters. While the parameter contains no sensitive data, overly aggressively configured checkers might flag the parameter.This PR resolves #955, at least in most cases. It should now be possible to use a custom bootstrap template and encrypt the CDK Bootstrap version parameter.
The change adds
WithDecryption: trueto the SSMgetParametercall. The flag is safe to always set because it's ignored for unencrypted parameters. When using AWS Managed Keys, SSM already has the necessary decryption permissions by default via Key policy. Otherwise it is up to the user to ensure sufficient decryption permissions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license