fix(integ-runner): assertion failures are incorrectly passing tests #1024
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 72 72
Lines 10087 10087
Branches 1330 1330
=======================================
Hits 8849 8849
Misses 1213 1213
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007
Integration tests were incorrectly reporting success even when assertions failed. The test output would show assertion failures in the CloudFormation stack outputs (with
"status":"fail"messages), but the integ-runner would still report the test as passed.This happened because the integ-runner wasn't passing the
outputsFileoption through to the toolkit-lib deploy method. Without this, assertion results were never written to disk and couldn't be evaluated by the test runner. The fix ensures theoutputsFilepath is properly resolved to an absolute path and passed through to the deploy method, allowing the runner to correctly detect and report assertion failures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license