getDummyObject to getDummyObjects

go-to-k · go-to-k · commit 8d9d94cd2e29 · 2025-03-23T03:36:55.000+09:00
fix test
diff --git a/packages/aws-cdk/lib/context-providers/cc-api-provider.ts b/packages/aws-cdk/lib/context-providers/cc-api-provider.ts
@@ -25,9 +25,9 @@ export class CcApiContextProviderPlugin implements ContextProviderPlugin {
       return result;
     } catch (err) {
       if (err instanceof ResourceNotFoundException) {
-        const dummyObject = this.getDummyObject(args);
-        if (dummyObject) {
-          return dummyObject;
+        const dummyObjects = this.getDummyObjects(args);
+        if (dummyObjects) {
+          return dummyObjects;
         }
       }
       throw err;
@@ -144,9 +144,9 @@ export class CcApiContextProviderPlugin implements ContextProviderPlugin {
     return resultObjs;
   }
 
-  private getDummyObject(args: CcApiContextQuery): {[key: string]: any}[] {
+  private getDummyObjects(args: CcApiContextQuery): {[key: string]: any}[] {
     if (!Array.isArray(args.dummyValue) || args.dummyValue.length === 0 || !args.dummyValue.every(value => typeof value === 'object' && value !== null)) {
-      throw new ContextProviderError(`dummyValue must be an array of objects. Failed to get dummy object for type ${args.typeName}.`);
+      throw new ContextProviderError(`dummyValue must be an array of objects. Failed to get dummy objects for type ${args.typeName}.`);
     }
 
     return args.dummyValue.map((dummyValue) => 
diff --git a/packages/aws-cdk/test/context-providers/cc-api-provider.test.ts b/packages/aws-cdk/test/context-providers/cc-api-provider.test.ts
@@ -405,7 +405,7 @@ describe('dummy value', () => {
         propertiesToReturn: ['DBInstanceArn', 'StorageEncrypted'],
         ignoreFailedLookup: true,
       }),
-    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy object for type AWS::RDS::DBInstance.');
+    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy objects for type AWS::RDS::DBInstance.');
   });
 
   test('throws error when CC API fails and dummyValue is not an array', async () => {
@@ -426,7 +426,7 @@ describe('dummy value', () => {
           StorageEncrypted: 'true',
         },
       }),
-    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy object for type AWS::RDS::DBInstance.');
+    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy objects for type AWS::RDS::DBInstance.');
   });
 
   test('throws error when CC API fails and dummyValue is an empty array', async () => {
@@ -444,7 +444,7 @@ describe('dummy value', () => {
         ignoreFailedLookup: true,
         dummyValue: [],
       }),
-    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy object for type AWS::RDS::DBInstance.');
+    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy objects for type AWS::RDS::DBInstance.');
   });
 
   test('throws error when CC API fails and dummyValue is not an object array', async () => {
@@ -464,7 +464,7 @@ describe('dummy value', () => {
           'not an object',
         ],
       }),
-    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy object for type AWS::RDS::DBInstance.');
+    ).rejects.toThrow('dummyValue must be an array of objects. Failed to get dummy objects for type AWS::RDS::DBInstance.');
   });
 });
 /* eslint-enable */

Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,9 @@ export class CcApiContextProviderPlugin implements ContextProviderPlugin {`
`25`	`25`	`return result;`
`26`	`26`	`} catch (err) {`
`27`	`27`	`if (err instanceof ResourceNotFoundException) {`
`28`		`- const dummyObject = this.getDummyObject(args);`
`29`		`- if (dummyObject) {`
`30`		`- return dummyObject;`
	`28`	`+ const dummyObjects = this.getDummyObjects(args);`
	`29`	`+ if (dummyObjects) {`
	`30`	`+ return dummyObjects;`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`	`throw err;`
`@@ -144,9 +144,9 @@ export class CcApiContextProviderPlugin implements ContextProviderPlugin {`
`144`	`144`	`return resultObjs;`
`145`	`145`	`}`
`146`	`146`
`147`		`- private getDummyObject(args: CcApiContextQuery): {[key: string]: any}[] {`
	`147`	`+ private getDummyObjects(args: CcApiContextQuery): {[key: string]: any}[] {`
`148`	`148`	`if (!Array.isArray(args.dummyValue) \|\| args.dummyValue.length === 0 \|\| !args.dummyValue.every(value => typeof value === 'object' && value !== null)) {`
`149`		- throw new ContextProviderError(`dummyValue must be an array of objects. Failed to get dummy object for type ${args.typeName}.`);
	`149`	+ throw new ContextProviderError(`dummyValue must be an array of objects. Failed to get dummy objects for type ${args.typeName}.`);
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`return args.dummyValue.map((dummyValue) =>`