feat(cfnspec): cloudformation spec v16.3.0#9452
Merged
mergify[bot] merged 7 commits intomasterfrom Aug 13, 2020
Merged
Conversation
This was referenced Aug 12, 2020
rix0rrr
previously approved these changes
Aug 13, 2020
rix0rrr
previously approved these changes
Aug 13, 2020
rix0rrr
previously approved these changes
Aug 13, 2020
rix0rrr
approved these changes
Aug 13, 2020
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
Author
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suspicious changes:
List<ItemType=Json>. They now moved that same broken definition into changed to aTagsproperty type.It's still incorrect but in a different place. Updating the patch to match new the location of the broken definition.
Optionstypes used to be defined asMap<String>, but are now typed asOptionswhich is itself a property typed defined with 0 properties. This leads us to drop all properties added there on the floor (because they're all not part of the schema). See: [cfnspec] CloudFormation Registry Schemas translation to CFN Specifications is lossy #9676