feat(core): schedule class#9250
Closed
kaizencc wants to merge 2 commits intoaws:masterfrom
kaizencc:schedule-core
Closed
feat(core): schedule class#9250kaizencc wants to merge 2 commits intoaws:masterfrom kaizencc:schedule-core
kaizencc wants to merge 2 commits intoaws:masterfrom
kaizencc:schedule-core
Conversation
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Im closing this PR for now, as it will not be implemented as a part of the synthetics L2. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Currently,
application autoscaling,autoscaling, andeventshave their ownscheduleclass that are very similar. They all support a subset of these static methods:at(moment),rate(duration),expression(expression), andcron(options). Because each resource has different ways of specifying itsscheduleclass, this PR is not as simple as moving the class to core and removing duplicates.Solution:
This PR moves the repetitive logic to
coreas aBaseScheduleclass, with all methodsprotected. It is called aBaseclass because other resources that have a need for ascheduleshould extend this and expose the necessary methods. This way, oneBaseScheduleclass can support multiple similar renditions of thescheduleproperty.Note:
BaseScheduleshould never need to be referenced by cdk users. This results in the PR Linter failure.autoscalingfollows the UNIX format with 5 units (source). However,application autoscalingandeventsfollows a slightly different format with 6 units (source). To accommodate both formats, I added an optionalunixparameter tocreateCronthat if set, will return a UNIX formatted cron expression.Closes #8979
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license