Skip to content

fix(events): cannot use the same target account for 2 cross-account event sources#8068

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
skinny85:fix/cloud-watch-events-multiple-accounts
May 21, 2020
Merged

fix(events): cannot use the same target account for 2 cross-account event sources#8068
mergify[bot] merged 3 commits intoaws:masterfrom
skinny85:fix/cloud-watch-events-multiple-accounts

Conversation

@skinny85
Copy link
Copy Markdown
Contributor

We hard code the SID of the EventBusPolicy that we generate in the account
of the target of a cross-account CloudWatch Event rule.
Which means that, if you have two sources in different accounts generating
events into the same target account,
you will get an error on CloudFormation deployment time about a duplicate SID.
Include the source account ID when generating the SID to make it unique.

Fixes #8010


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…vent sources

We hard code the SID of the EventBusPolicy that we generate in the account
of the target of a cross-account CloudWatch Event rule.
Which means that, if you have two sources in different accounts generating
events into the same target account,
you will get an error on CloudFormation deployment time about a duplicate SID.
Include the source account ID when generating the SID to make it unique.

Fixes aws#8010
@skinny85 skinny85 requested a review from rix0rrr May 19, 2020 01:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 19, 2020
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4044dd4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f006125
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fb26b70
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 395c07c into aws:master May 21, 2020
@skinny85 skinny85 deleted the fix/cloud-watch-events-multiple-accounts branch May 21, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot create multiple AWS Events Rules for different accounts

3 participants