chore(codebuild): wrong scope for SourceCredentials#6778
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Mar 18, 2020
Merged
chore(codebuild): wrong scope for SourceCredentials#6778mergify[bot] merged 2 commits intoaws:masterfrom
mergify[bot] merged 2 commits intoaws:masterfrom
Conversation
Accidentally used the parent scope for two of the SourceCredentials L2, instead of the correct `this`.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
reviewed
Mar 18, 2020
| super(scope, id); | ||
|
|
||
| new CfnSourceCredential(scope, 'Resource', { | ||
| new CfnSourceCredential(this, 'Resource', { |
eladb
approved these changes
Mar 18, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally used the parent scope for two of the SourceCredentials L2,
instead of the correct
this.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license