chore(cli): CLI uses cdk-assets to upload templates and assets#6742
chore(cli): CLI uses cdk-assets to upload templates and assets#6742mergify[bot] merged 2 commits intomasterfrom
cdk-assets to upload templates and assets#6742Conversation
Centralize all logic about how templates, files and container assets are built and uploaded in the `cdk-assets` tool. We need this change first because it's on the critical path of the CLI being able to deploy using the new convention mode roles (which requires the CLI to use the asset publishing role for uploading the CloudFormation templates), which is required for the pipeline being able to do self-mutation using `cdk deploy`. We can roll this change out independently of the framework emitting the asset manifest (the CLI can generate it) and we don't need to assume any roles, while we still get to test the new code path. Also importing a number of improvements to `cdk-assets` from the proof-of-concept branch. ----------- In addition to the previous attempt at this feature: handle it properly when asset manifest contains absolute instead of relative paths.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
I had an issue with this PR. Before, I could do this: const dockerImage = new DockerImageAsset(this, "DockerImageAsset", {
directory: "..",
file: "server/Dockerfile"
});And the file prop was relative to the directory ( |
Centralize all logic about how templates, files and container assets
are built and uploaded in the
cdk-assetstool.We need this change first because it's on the critical path of the CLI
being able to deploy using the new convention mode roles (which requires
the CLI to use the asset publishing role for uploading the
CloudFormation templates), which is required for the pipeline
being able to do self-mutation using
cdk deploy.We can roll this change out independently of the framework emitting
the asset manifest (the CLI can generate it) and we don't need
to assume any roles, while we still get to test the new code path.
Also importing a number of improvements to
cdk-assetsfrom theproof-of-concept branch.