fix(logs): retentionInDays can't be a Token#6727
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Mar 17, 2020
nmoutschen:master
Merged
fix(logs): retentionInDays can't be a Token#6727mergify[bot] merged 2 commits intoaws:masterfrom nmoutschen:master
mergify[bot] merged 2 commits intoaws:masterfrom
nmoutschen:master
Conversation
…kens Prevents performing validation on the retention property for LogGroups if the token is unresolved (e.g. a CloudFormation Parameter). Otherwise, running the command `cdk synth` could fail with the following error message: ``` retentionInDays must be positive, got -1.888154589708755e+289 ``` The new unit test creates a LogGroup with a retention property that refers to a CloudFormation parameter to ensure that the stack synthesizes properly. fixes #6690
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Mar 17, 2020
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents performing validation on the retention property for LogGroups
if the token is unresolved (e.g. a CloudFormation Parameter). Otherwise,
running the command
cdk synthcould fail with the following errormessage:
The new unit test creates a LogGroup with a retention property that
refers to a CloudFormation parameter to ensure that the stack
synthesizes properly.
fixes #6690
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license