Skip to content

feat(ec2): makes availabilityZone optional in SubnetAttributes, get Subnet from subnetId fixes#6607#6667

Merged
mergify[bot] merged 40 commits intoaws:masterfrom
nirvana124:nirvana124/AZ_optional
Mar 17, 2020
Merged

feat(ec2): makes availabilityZone optional in SubnetAttributes, get Subnet from subnetId fixes#6607#6667
mergify[bot] merged 40 commits intoaws:masterfrom
nirvana124:nirvana124/AZ_optional

Conversation

@nirvana124
Copy link
Copy Markdown
Contributor

@nirvana124 nirvana124 commented Mar 11, 2020 •
edited by rix0rrr
Loading

Description

availabilityZone attribute inside SubnetAttributes is only used for subnet selection.
AZ restrictions are not mandatory so making availabilityZone as optional.
Also as AZ is optional we should be able to search subnet using only subnet id.
Added fromSubnetId as well.

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Commit Message

feat(ec2): availabilityZone is optional when importing subnet

availabilityZone attribute inside SubnetAttributes is only used for subnet selection.
AZ restrictions are not mandatory so making availabilityZone as optional.
Also as AZ is optional we should be able to search subnet using only subnet id.
Added fromSubnetId as well.

fixes #6607

pankajy93 and others added 15 commits February 28, 2020 18:08
@pankajy93
fix(apigateway): Allows configuring authorization scopes in apigatewa…
375a157 
…y method fixes#6390
@pankajy93
Fixes build failure for Case sensitive fields
37249b2
@nirvana124
Merge branch 'master' into master
bab8d99
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
71ab433 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
26c31ea 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
14dfbe7 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
4612c83 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
87cbb71 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124
Merge branch 'master' into master
07a3188
@pankajy93
Added test cases to cover auth scopes absent and method options auth …
49d3752 
…scope take the priority in case method options and default options are passed
@pankajy93
Updating readme for authorizationScopes
3399253
@pankajy93
removing trailing white space to fix @aws-cdk/aws-apigateway: ERROR: …
913df38 
…/codebuild/output/src052287507/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-apigateway/lib/method.ts:80:87 - trailing whitespace
@nirvana124
Merge branch 'master' into master
3f451f7
@nirvana124
Merge branch 'master' into master
9b558f4
@pankajy93
feat(ec2): makes availabilityZone optional in SubnetAttributes, get S…
247c3fa 
…ubnet from subnetId fixes#6607
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 247c3fa
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7216c7e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 18eb9b0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 99e295e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 44b99e2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7b33f0f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0795ad2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 11, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5fbb22c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 391c74a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 69f30b5
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 505574b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nirvana124
Copy link
Copy Markdown
Contributor Author

nirvana124 commented Mar 16, 2020

@rix0rrr reverted SubnetAttributes.availabilityZone to mandatory
Passing empty string to availabilityZone while using fromSubnetId
changed availabilityZone inside ImportedSubnet to getter and throwing error if _availabilityZone is undefined. Written test cases for the same as well.
please review and let me know if need to do any other changes in code

rix0rrr
rix0rrr previously requested changes Mar 16, 2020
View reviewed changes
@mergify mergify bot dismissed rix0rrr’s stale review March 16, 2020 12:04

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d4cf567
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 350cc59
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: afc586a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nirvana124
Copy link
Copy Markdown
Contributor Author

nirvana124 commented Mar 16, 2020

@rix0rrr Requested changes are done.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 16, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1e0b5f8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0dc7c24
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nirvana124 nirvana124 requested a review from rix0rrr March 17, 2020 04:39
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cc30b37
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 676dc62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d10fe67 into aws:master Mar 17, 2020
@nirvana124 nirvana124 deleted the nirvana124/AZ_optional branch March 17, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

+1 more reviewer

@pankajy93 pankajy93 pankajy93 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rix0rrr rix0rrr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

availabilityZone is mandatory inside SubnetAttributes while using Subnet.fromSubnetAttributes

4 participants

@nirvana124 @aws-cdk-automation @rix0rrr @pankajy93