Skip to content

fix: SecretValue.secretManager validates non-ARN ids do not contain :#6371

Merged
mergify[bot] merged 7 commits intoaws:masterfrom
ahammond:validate_secretid
Mar 17, 2020
Merged

fix: SecretValue.secretManager validates non-ARN ids do not contain :#6371
mergify[bot] merged 7 commits intoaws:masterfrom
ahammond:validate_secretid

Conversation

@ahammond
Copy link
Contributor

@ahammond ahammond commented Feb 19, 2020 •
edited
Loading

Fixes #6272

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Feb 19, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ahammond ahammond changed the title SecretValue.secretManager validates non-ARN ids do not contain : fix: SecretValue.secretManager validates non-ARN ids do not contain : Feb 19, 2020
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 19, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2cd8a42
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 19, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 22f2a3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahammond ahammond requested a review from eladb February 24, 2020 18:29
eladb
eladb previously requested changes Feb 24, 2020
View reviewed changes
@ahammond
Update packages/@aws-cdk/core/lib/secret-value.ts
c000280 
Co-Authored-By: Elad Ben-Israel <benisrae@amazon.com>
@mergify mergify bot dismissed eladb’s stale review February 24, 2020 23:34

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 24, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c000280
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 25, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 21b707b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 previously requested changes Mar 12, 2020
View reviewed changes
@mergify mergify bot dismissed skinny85’s stale review March 12, 2020 20:20

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 12, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8cff5ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 12, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 379a3b5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 22a2dd3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7cb8c3f into aws:master Mar 17, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Closed
@ahammond ahammond deleted the validate_secretid branch April 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@skinny85 skinny85 skinny85 approved these changes

@eladb eladb eladb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@skinny85 skinny85

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SecretValue.secretsManager should validate input doesn't contain :

4 participants

@ahammond @aws-cdk-automation @skinny85 @eladb