feat(appsync): add support for mapping DynamoDB queries#5940
feat(appsync): add support for mapping DynamoDB queries#5940mergify[bot] merged 2 commits intoaws:masterfrom
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
ping |
|
Thanks for the heads up, @MrArnoldPalmer! :) |
MrArnoldPalmer
left a comment
There was a problem hiding this comment.
This feels like a great addition. I think we should add integ coverage of the other KeyConditions. Otherwise good to go.
I wonder if we can keep building on top of this to abstract away some of the dynamo specifics. Separate discussion though.
| customerDS.createResolver({ | ||
| typeName: 'Query', | ||
| fieldName: 'getCustomerOrders', | ||
| requestMappingTemplate: MappingTemplate.dynamoDbQuery(KeyCondition.eq('id', 'id')), |
There was a problem hiding this comment.
I think we should add coverage for the other KeyConditions we have defined. It's a bit tedious but feels like it will payoff in the long run.
There was a problem hiding this comment.
Will do! Thanks for reviewing :)
Yeah, I think that would be a good direction. The current mappings only support basic usage (e.g., |
Add support to the L2 AppSync constructs for mapping DynamoDB queries. Fixes aws#5861 Signed-off-by: Duarte Nunes <duarte@uma.ni>
7e11115 to
c92200e
Compare
Pull request has been modified.
|
PR updated with the remaining tests. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
Add support to the L2 AppSync constructs for mapping DynamoDB queries.
Fixes #5861
Signed-off-by: Duarte Nunes duarte@uma.ni
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license