fix(cli): cdk bootstrap is broken due to --no-execute#5092
Merged
mergify[bot] merged 1 commit intomasterfrom Nov 19, 2019
Merged
fix(cli): cdk bootstrap is broken due to --no-execute#5092mergify[bot] merged 1 commit intomasterfrom
mergify[bot] merged 1 commit intomasterfrom
Conversation
The change that introduced the `--no-execute` feature (#4852) did not take into account that `cdk bootstrap` uses the same code path for deployment, and therefore `execute` was undefined, and resolved to false (despite the documented default). This change moves `execute` switch from the global scope into `deploy` and to `bootstrap` and passes it into the `cliBootstrap` command, as well as respects the default in case the option passed to the deployment utility is `undefined`. It also emits a message to STDOUT in case `--no-execute` is provided to let user know that deployment hasn't really finished. Otherwise, it appears as if deployment is successful. The `deploy-no-execute` integration test was also "failing successfully" due to invalid usage of bash conditions, so this is also fixed here. Added integration test to verify that --no-execute is respected by `cdk bootstrap`.
Contributor
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
rix0rrr
approved these changes
Nov 19, 2019
shivlaks
approved these changes
Nov 19, 2019
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request is now being automatically merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change that introduced the
--no-executefeature (#4852) did not take into account thatcdk bootstrapuses the same code path for deployment, and thereforeexecutewas undefined, and resolved to false (despite the documented default).This change moves
executeswitch from the global scope intodeployand tobootstrapand passes it into thecliBootstrapcommand, as well as respects the default in case the option passed to the deployment utility isundefined.It also emits a message to STDOUT in case
--no-executeis provided to let user know that deployment hasn't really finished. Otherwise, it appears as if deployment is successful.The
deploy-no-executeintegration test was also "failing successfully" due to invalid usage of bash conditions, so this is also fixed here.Added integration test to verify that --no-execute is respected by
cdk bootstrap.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license