Merged
Conversation
eladb
suggested changes
Nov 13, 2019
Contributor
eladb
left a comment
There was a problem hiding this comment.
Please include [this commit] in the patch release. It's a P0 regression.
eladb
suggested changes
Nov 13, 2019
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…4998) Legacy mode for #4895 still used the uniquely generated id instead of the stack name as the artifact ID in the cloud assembly. The implications were that even if users were not opted-in to the new behavior (through the feature flag), they could not use the stack name in the CLI because the stack artifact ID was still new. This fix ensures that if the feature flag is not enabled, the artifact ID itself uses the stack name, hence allowing users to query by stack name as long as they are not opted in to the new behavior. Fixes #4997
See CHANGELOG
058cf65 to
91b882d
Compare
Contributor
Author
|
@eladb - amended commit chain to include that (I'll be updating the main description now, too) |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Nov 13, 2019
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsiito0.20.5(fixes .NET CDK 1.16.2 JsiiException exception on synth at CodeCommit.Repository.OnCommit #4989, fixes invoking add_ingress_rule() on an imported security group throws AttributeError: 'Resource' object has no attribute 'add_ingress_rule' #4966, fixes .NET CDK ignores integration options & method responses in API Gateway methods #1904, fixes CDK for .NET does not use the compiler to flag construct required properties #1845)ecs-patternslibrary bug [ecs-patterns; ApplicationLoadBalancedFargateService] When attaching certificate, target group protocol set to that of listener protocol #4983By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license