Skip to content

feat(custom-resources): allow specifying role for AwsCustomResource#4909

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
jogold:aws-custom-role
Nov 10, 2019
Merged

feat(custom-resources): allow specifying role for AwsCustomResource#4909
mergify[bot] merged 3 commits intoaws:masterfrom
jogold:aws-custom-role

Conversation

@jogold
Copy link
Copy Markdown
Contributor

@jogold jogold commented Nov 7, 2019

Also removed useless console.log outputs from tests

Closes #4906

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
feat(custom-resources): allow specifying role for AwsCustomResource
f64e96b 
Also removed console.log outputs from tests

Closes aws#4906
@jogold jogold requested a review from eladb as a code owner November 7, 2019 20:07
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 7, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 7, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously requested changes Nov 7, 2019
View reviewed changes
packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts Outdated

/**
* The execution role for the Lambda function implementing this custom
* resource. The role must be assumable by the `lambda.amazonaws.com`
Copy link
Copy Markdown
Contributor

@eladb eladb Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is implementing the "custom resource provider". It's an important distinction because it's a singleton, so the role will apply to all AwsCustomResource instances in your app. Probably fine, but worth documenting.

@mergify mergify bot dismissed eladb’s stale review November 8, 2019 08:51

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 8, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 10, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 98fb888 into aws:master Nov 10, 2019
@jogold jogold deleted the aws-custom-role branch November 11, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@eladb eladb eladb approved these changes

@reillykw reillykw reillykw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eladb eladb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Permit IAM Role Injection Into AwsCustomResource

4 participants

@jogold @aws-cdk-automation @eladb @reillykw