Skip to content

feat(ecs): add cloudMapNamespace as a property of cloudMapOptions#4890

Merged
mergify[bot] merged 4 commits intoaws:masterfrom
piradeepk:addCloudmapNamespace
Nov 11, 2019
Merged

feat(ecs): add cloudMapNamespace as a property of cloudMapOptions#4890
mergify[bot] merged 4 commits intoaws:masterfrom
piradeepk:addCloudmapNamespace

Conversation

@piradeepk
Copy link
Copy Markdown
Contributor

@piradeepk piradeepk commented Nov 7, 2019

Add cloudMapNamespace as a property of cloudMapOptions so that users can override the default cloudmap namespace defined in the cluster.

Fixes: #4677

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@piradeepk piradeepk requested a review from SoManyHs as a code owner November 7, 2019 00:41
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 7, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@piradeepk piradeepk requested a review from rix0rrr November 7, 2019 00:42
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 7, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr reviewed Nov 7, 2019
View reviewed changes
@piradeepk piradeepk force-pushed the addCloudmapNamespace branch from 62b4f12 to 153bc6b Compare November 7, 2019 18:18
@piradeepk piradeepk requested a review from rix0rrr November 7, 2019 18:19
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 7, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 7, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr reviewed Nov 8, 2019
View reviewed changes
@SomayaB SomayaB added @aws-cdk/aws-ecs Related to Amazon Elastic Container contribution/core This is a PR that came from AWS. labels Nov 8, 2019
@piradeepk piradeepk force-pushed the addCloudmapNamespace branch from 9091e56 to 5bff7b8 Compare November 8, 2019 17:50
@piradeepk piradeepk requested a review from rix0rrr November 8, 2019 17:54
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 8, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 8, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 11, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 06caf4f into aws:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@SoManyHs SoManyHs

Labels

@aws-cdk/aws-ecs Related to Amazon Elastic Container contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow setting Cloudmap namespace on ECS Service

5 participants

@piradeepk @aws-cdk-automation @rix0rrr @SomayaB @SoManyHs