Skip to content

fix(dynamodb): invalid ARN for autoscaling role#4854

Merged
mergify[bot] merged 1 commit intomasterfrom
huijbers/ddb-auto-scaling
Nov 5, 2019
Merged

fix(dynamodb): invalid ARN for autoscaling role#4854
mergify[bot] merged 1 commit intomasterfrom
huijbers/ddb-auto-scaling

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Nov 5, 2019

The Role ARN should not contain the region, as the 'iam' service
is region-independent.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
fix(dynamodb): Fix AutoScaling role ARN
78934e5 
The Role ARN should not contain the region, as the 'iam' service
is region-independent.
@rix0rrr rix0rrr self-assigned this Nov 5, 2019
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@eladb eladb changed the title fix(dynamodb): Fix AutoScaling role ARN fix(dynamodb): invalid ARN for autoscaling role Nov 5, 2019
eladb
eladb approved these changes Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rephrased your title to represent the issue fixed and not the fix itself.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit fc054e9 into master Nov 5, 2019
@mergify mergify bot deleted the huijbers/ddb-auto-scaling branch November 5, 2019 13:59
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

@skinny85 skinny85 Awaiting requested review from skinny85

@shivlaks shivlaks Awaiting requested review from shivlaks

1 more reviewer

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rix0rrr rix0rrr

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rix0rrr @aws-cdk-automation @eladb @SomayaB