Skip to content

feat(events): support event bus for rule#4839

Merged
mergify[bot] merged 4 commits intoaws:masterfrom
jogold:rule-event-bus
Nov 6, 2019
Merged

feat(events): support event bus for rule#4839
mergify[bot] merged 4 commits intoaws:masterfrom
jogold:rule-event-bus

Conversation

@jogold
Copy link
Copy Markdown
Contributor

@jogold jogold commented Nov 4, 2019

Adds an eventBus prop to the Rule construct.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold jogold requested a review from eladb as a code owner November 4, 2019 13:46
@jogold
Copy link
Copy Markdown
Contributor Author

jogold commented Nov 4, 2019

Branched from huijbers/cfnspec-7.3.0 #4838

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 4, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
feat(events): support event bus for rule
afb8bc3 
Adds an `eventBus` prop to the `Rule` construct.
@dehli dehli mentioned this pull request Nov 4, 2019
Closed
4 tasks
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 4, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 6, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 6, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f5858ba into aws:master Nov 6, 2019
@jogold jogold deleted the rule-event-bus branch November 11, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@eladb eladb Awaiting requested review from eladb

Assignees

@rix0rrr rix0rrr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jogold @aws-cdk-automation @rix0rrr