Skip to content

fix(codepipeline): the CodeBuild action now works with imported projects#4637

Merged
mergify[bot] merged 2 commits intoaws:masterfrom
skinny85:bug/imported-codebuild-project
Oct 23, 2019
Merged

fix(codepipeline): the CodeBuild action now works with imported projects#4637
mergify[bot] merged 2 commits intoaws:masterfrom
skinny85:bug/imported-codebuild-project

Conversation

@skinny85
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 commented Oct 22, 2019

Because of the way the IAM library was used in the CodeBuild CodePipeline action,
it was not possible to provide an imported project to the action
(it would result in an error being thrown from the IAM library for the KMS key permissions).

Fixes #4613

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85
fix(codepipeline): the CodeBuild action now works with imported projects
6869df2 
Because of the way the IAM library was used in the CodeBuild CodePipeline action,
it was not possible to provide an imported project to the action
(it would result in an error being thrown from the IAM library for the KMS key permissions).

Fixes aws#4613
@skinny85 skinny85 requested a review from rix0rrr October 22, 2019 19:14
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 22, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Oct 22, 2019
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 22, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 23, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 23, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6c4085e into aws:master Oct 23, 2019
@skinny85 skinny85 deleted the bug/imported-codebuild-project branch October 23, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@skinny85 skinny85

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using imported code build project for CodeBuildAction results in "resource imported without a role"

4 participants

@skinny85 @aws-cdk-automation @rix0rrr @SomayaB