feat(appsync): add L2 constuct for AppSync by hoegertn · Pull Request #4438 · aws/aws-cdk

hoegertn · 2019-10-09T22:59:00Z

Add L2 constructs for AppSync

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mergify · 2019-10-09T22:59:36Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-10-09T23:05:54Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-10T08:06:37Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-10T08:06:44Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hoegertn · 2019-10-16T05:01:27Z

@shivlaks @eladb Any feedback on this? It would be great if we could get this added.

shivlaks · 2019-10-16T05:12:30Z

@hoegertn - hey, thanks for getting the ball rolling. I'll take a look and start getting my thoughts together as we work through these. While I ramp up, are there specific use cases with AppSync we're aiming to start with? Or resources that are challenging to use?

aws-cdk-automation · 2019-10-16T05:36:00Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hoegertn · 2019-10-16T07:05:52Z

Hi, I started with datasources of type DynamoDB and Lambda, but I can provide the rest if the architecture is ok.

The main features/benefits are:

Support for higher-level constructs Table, Function, etc
Auto-creation of IAM Roles and Policies
File access to extract schema, mapping templates, etc

packages/@aws-cdk/aws-appsync/lib/graphqlapi.ts

aws-cdk-automation · 2019-10-21T08:39:05Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-21T08:56:59Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-21T09:01:29Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-21T13:02:33Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-21T14:00:33Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-22T05:48:24Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-23T16:39:59Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hoegertn · 2019-10-24T05:33:01Z

@shivlaks Do you think we can proceed here? I would love to have this in a release any time soon, as I am using this for several projects already.

aws-cdk-automation · 2019-10-24T06:19:43Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-10-28T16:30:44Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks

this is a great start, what areas did you want to cover first. I think it's better to start small and vet it's usage. Would the DynamoDB data source be a good choice?

shivlaks · 2019-11-12T02:01:22Z

packages/@aws-cdk/aws-appsync/README.md

+    });
+    const customerDS = api.addDynamoDbDataSource('Customer', 'The customer data source', customerTable);
+    customerDS.createResolver({
+      typeName: 'Query',


are these something we'd want in an enum? I'm assuming they're finite & have a few values that are valid

THis is a free text and could be anything the user wants

good point, finally started reading the user guide to get caught up here

shivlaks · 2019-11-12T02:07:43Z

packages/@aws-cdk/aws-appsync/README.md

+      },
+      userPoolConfig: {
+        userPool,
+        defaultAction: UserPoolDefaultAction.ALLOW,


is this required / what would the default be?

shivlaks · 2019-11-12T02:09:32Z

packages/@aws-cdk/aws-appsync/README.md

+      requestMappingTemplate: MappingTemplate.dynamoDbGetItem('id', 'id'),
+      responseMappingTemplate: MappingTemplate.dynamoDbResultItem(),


I believe these could also point to an S3 location or accept them directly as string right?

You can also write MappingTemplate.fromFile() or MappingTemplate.fromString()

packages/@aws-cdk/aws-appsync/test/integ.graphql.expected.json

aws-cdk-automation · 2019-11-18T22:14:10Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-18T22:46:19Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-18T22:47:33Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-18T23:12:34Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-18T23:16:43Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hoegertn · 2019-11-18T23:18:32Z

@shivlaks can we get this merged?

shivlaks · 2019-11-22T01:50:44Z

@shivlaks can we get this merged?

Hey @hoegertn - code looks fine to me! Seems like there's still a conflict that needs resolution.

hoegertn · 2019-11-22T13:08:59Z

I merged in the latest release. It would be great if we could get this into master.

aws-cdk-automation · 2019-11-22T13:37:29Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks · 2019-11-22T21:42:26Z

@hoegertn LTGM. hang tight, we'll start merging community contributions again in a couple days!

aws-cdk-automation · 2019-11-22T22:35:26Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2019-11-28T04:03:25Z

Thank you for contributing! Your pull request is now being automatically merged.

Pull request has been modified.

aws-cdk-automation · 2019-11-28T05:36:00Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hoegertn · 2019-11-28T07:10:29Z

@shivlaks Hi, can you please approve again? I had to merge master in, due to conflicts.

shivlaks · 2019-11-29T03:36:02Z

@hoegertn - done, excited to start growing this L2 and filling in the rest!

aws-cdk-automation · 2019-11-29T04:00:51Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feat(appsync): add L2 constuct for AppSync

dd4d586

hoegertn requested a review from shivlaks as a code owner October 9, 2019 22:59

SomayaB assigned shivlaks Oct 9, 2019

hoegertn mentioned this pull request Oct 10, 2019

Support higher level constructs for AppSync #4277

Closed

2 tasks

hoegertn added 2 commits October 10, 2019 09:24

fix(appsync): tests

e818aab

Merge branch 'master' into appsync-l2

fe4580c

Merge branch 'master' into appsync-l2

e291489

ranguard reviewed Oct 16, 2019

View reviewed changes

packages/@aws-cdk/aws-appsync/lib/graphqlapi.ts Outdated Show resolved Hide resolved

hoegertn added 2 commits October 21, 2019 10:23

Merge branch 'master' into appsync-l2

9d2dab8

fix: feedback

b458304

fix: feedback

9f19025

shivlaks reviewed Nov 12, 2019

View reviewed changes

hoegertn added 2 commits November 18, 2019 23:18

more comments

8ea282b

Merge branch 'master' into appsync-l2

78cd8da

hoegertn added 2 commits November 18, 2019 23:48

Merge branch 'master' into appsync-l2

a60c54d

Merge branch 'master' into appsync-l2

8cc7f10

Merge branch 'master' into appsync-l2

aaf1724

Merge branch 'master' into appsync-l2

55dd967

shivlaks previously approved these changes Nov 28, 2019

View reviewed changes

Merge branch 'master' into appsync-l2

19c71e7

shivlaks approved these changes Nov 29, 2019

View reviewed changes

Merge branch 'master' into appsync-l2

eed95fc

mergify bot merged commit 226b27a into aws:master Nov 29, 2019

hoegertn deleted the appsync-l2 branch December 6, 2019 01:21

bartcallant mentioned this pull request Feb 2, 2020

High level construct for an AppSync Elasticsearch data source #6063

Closed

2 tasks

		requestMappingTemplate: MappingTemplate.dynamoDbGetItem('id', 'id'),
		responseMappingTemplate: MappingTemplate.dynamoDbResultItem(),

Conversation

hoegertn commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Oct 9, 2019

Uh oh!

aws-cdk-automation commented Oct 9, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 10, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 10, 2019

AWS CodeBuild CI Report

Uh oh!

hoegertn commented Oct 16, 2019

Uh oh!

shivlaks commented Oct 16, 2019

Uh oh!

aws-cdk-automation commented Oct 16, 2019

AWS CodeBuild CI Report

Uh oh!

hoegertn commented Oct 16, 2019

Uh oh!

Uh oh!

aws-cdk-automation commented Oct 21, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 21, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 21, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 21, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 21, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 22, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 23, 2019

AWS CodeBuild CI Report

Uh oh!

hoegertn commented Oct 24, 2019

Uh oh!

aws-cdk-automation commented Oct 24, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Oct 28, 2019

AWS CodeBuild CI Report

Uh oh!

shivlaks left a comment

Choose a reason for hiding this comment

Uh oh!

shivlaks Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

hoegertn Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

shivlaks Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

shivlaks Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

shivlaks Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

hoegertn Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aws-cdk-automation commented Nov 18, 2019

AWS CodeBuild CI Report

Uh oh!

aws-cdk-automation commented Nov 18, 2019

hoegertn commented Oct 9, 2019 •

edited

Loading