fix(stepfunctions): unable to run distributed map when only defined in nested StateGraphs#35417
Merged
mergify[bot] merged 4 commits intoaws:mainfrom Sep 9, 2025
Conversation
kumvprat
reviewed
Sep 5, 2025
...ws-cdk-testing/framework-integ/test/aws-stepfunctions/test/integ.distributed-map-parallel.ts
Show resolved
Hide resolved
Kasra-G
commented
Sep 5, 2025
Kasra-G
commented
Sep 5, 2025
This comment was marked as resolved.
This comment was marked as resolved.
fddcaa1 to
4d35364
Compare
4d35364 to
ceb1685
Compare
kumvprat
approved these changes
Sep 9, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
Closes #35391.
Reason for this change
When the only instances of DistributedMap states were inside nested StateGraphs (most commonly reported as Parallel branches, see #28820),
StateGraph.bindwould fail to find these DistributedMaps and thus fail to add the necessary DistributedMap policies to the state machine's execution role. This means the state machine execution would fail as soon as it got to the nested DistributedMap state.This was originally included in #34760, but aligned that it should go into its own PR #34760 (comment)
Description of changes
This change allows DistributedMap states in any level of nested StateGraphs to be discovered and considered for the DistributedMap policy additions.
Changes:
bind()method to find DistributedMap statesThe idea of recursing through state graphs can be attributed to #29913, but to avoid the recursion, I just converted the logic to use a loop.
Describe any new or updated permissions being added
State machines with a DistributedMap state inside a Parallel branch will now receive the proper policy for execution (Documented here: https://docs.aws.amazon.com/step-functions/latest/dg/iam-policies-eg-dist-map.html#iam-policy-run-dist-map)
Description of how you validated changes
Unit & new Integ test that deploys and runs a StateMachine with a DistributedMap inside a Parallel state.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license