chore(prlint): add need-xxx-reviews when building with github action#35326
chore(prlint): add need-xxx-reviews when building with github action#35326mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
kumvprat
left a comment
There was a problem hiding this comment.
The new codebuild check also does commit status update.
Maybe that would be a better check as the status are updated when the workflow run is completed, this way for each commit the PR linter might not be successful in reporting the status of ongoing builds and mi9ght need to run again/run post codebuild workflow runs are complete
| # Triggered from a separate job when a review is added | ||
| workflow_run: | ||
| workflows: [PR Linter Trigger] | ||
| workflows: ["PR Linter Trigger", "Codebuild PR Build"] |
There was a problem hiding this comment.
This should trigger the linter workflow again and add proper label based on Codebuild Action's result
kumvprat
left a comment
There was a problem hiding this comment.
Overall the changes look good, main points to verify :
- Does CodeBuild job completion trigger the linter workflow ?
- Does the
listWorkflowRunsclient call support the data object being passed as a parameter?
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35268.
Reason for this change
When moving the builds to github actions,
need-xxx-reviewlabels were not added anymore.Description of changes
Fetch the build status from the github action, remove support for
StatusEventGithub actions don't use it (only the direct Codebuild integration used it)Description of how you validated changes
Manually ran the script for a few PR's locally, updated unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license